Staredit Network

Staredit Network -> SEN v5 Alpha -> Message Center
Report, edit, etc...Posted by LegacyWeapon on 2005-06-10 at 18:12:31
He fixed it so you could always send messages to yourself tongue.gif
Report, edit, etc...Posted by IsolatedPurity on 2005-06-10 at 18:12:51
Ah... I see... tab order is one thing I haven't really used too much throughout the site except in the message compose section.

Will fix... thanks...
Report, edit, etc...Posted by LegacyWeapon on 2005-06-10 at 18:19:20
If you try to enter the same person's username more than once when trying to send a PM, it will have an incorrect error message:
CODE
The action you performed failed.
Reasons(s) returned:
ยป One or more members do not exist. Check your names again before sending.


ADDITION:
Also, trying to make your folder named blank will cause this error:
CODE
Fatal error: Call to a member function on a non-object in /home/is047s3n/public_html/1337v5/scripts/messages/set_folders.php on line 50


ADDITION:
Naming a folder space (" ") will cause it to be named blank, so when you press submit again, it will give the blank folder name error.
Report, edit, etc...Posted by RexyRex on 2005-06-10 at 18:19:54
Not entering a name in the block list gives a warning saying that the member doesn't exist.
Report, edit, etc...Posted by LegacyWeapon on 2005-06-10 at 18:23:13
Adding a blank contact to your address book gives you this error:
CODE
Query failed : SELECT b_mid FROM message_abook WHERE o_mid=24 AND b_mid =
(1064): You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1
Report, edit, etc...Posted by BeeR_KeG on 2005-06-10 at 18:24:23
When Forwarding a PM the reciever can't really distinguish easily the difference between what was Forwarded and the new text of the PM.

I PM'ed RexyRex~PM, shmeeps, BeeR_KeG, BeeR_KeG Testing
Post if both the PM and FWD worked. This is to test sending to multiple users at once.
Report, edit, etc...Posted by Shmeeps on 2005-06-10 at 18:25:24
You need to put a limit on custom folder wink.gif

[attachmentid=10198]


EDIT: Yeah, I got them both BeeR. happy.gif
Report, edit, etc...Posted by RexyRex on 2005-06-10 at 19:19:42
If you use a name in the address book, then type the same name in the names textarea, you get a warning saying the user doesn't exist and it adds the name in the textarea... compared to selecting the name from the address book.

ADDITION:
QUOTE(isolatedpurity @ Jun 10 2005, 02:25 PM)
What?
[right][snapback]231659[/snapback][/right]

Editing someone in your contacts gives you a blank critical error.
Report, edit, etc...Posted by IsolatedPurity on 2005-06-10 at 23:09:38
Okay... Give me a chance to go through this topic and look at everything... no more posts for now smile.gif.
Report, edit, etc...Posted by Slyence on 2005-06-10 at 23:24:15
Here is something I just figured out...

When you send a message to someone, It doesnt say Sent Messages (1)

It just stays at Sent Messages (0)...

(Oops didnt see your post biggrin.gif sorry IP smile.gif)
Report, edit, etc...Posted by Shmeeps on 2005-06-10 at 23:36:31
Breaking IP's rule for a sec...

It's cause you didn't check the box that says "Save to $sentboxfoldername".
Report, edit, etc...Posted by Slyence on 2005-06-10 at 23:46:55
I did... I tryed it both ways.
Report, edit, etc...Posted by Shmeeps on 2005-06-11 at 00:02:15
Hmm, it worked for me...
Report, edit, etc...Posted by IsolatedPurity on 2005-06-11 at 00:59:03
Unresolved Issues
  • Anything with saved messages
  • Anything with sent messages
  • PM forwarding... not exactly sure on how I will do this.
  • Mass altered functions (move, delete)
  • Check names + find names links
  • Empty signature / avatar boxxes (I checked a PM, and the boxxes seem sorta distorted. I don't know what half of them are...see for yourself in the screenshot.)

Fixxed
But like always... don't take my word for it smile.gif.

Legacy: Could you make tabbing from "Quick Reply" textbox go to the "Reply" button?
Yup.

Rexy: Editing someone in your contacts gives you a blank critical error.
I finally found what you were talking about! It was a misspelling by me smile.gif.

Legacy: Also, trying to make your folder named blank will cause this error
Legacy: Naming a folder space (" ") will cause it to be named blank, so when you press submit again, it will give the blank folder name error.
I did account for these! I just... forgot to tell my function that it's okay to call another class... and such smile.gif.

Legacy: Adding a blank contact to your address book gives you this error... [sql failure]
Rexy: Not entering a name in the block list gives a warning saying that the member doesn't exist.
These last two were exceptionally noobish of me because I didn't even attempt to account for them!

Legacy & others: If you try to enter the same person's username more than once when trying to send a PM, it will have an incorrect error message
The data array that holds all the entered names now auto truncates duplicated copies. This will also fix if you entered a single user from the address book and the same user in the entered field. ALTHOUGH, if someone enters someone's name more than one, I'd probably think they were trying to spam the user on purpose and giving them a critical error would probably feed my need to annoy idiots who wish to do things such as.
However, if you select the user from a "mass send" group and then also write their name in, it will give you a warning. At least, it did when I tried it...

Sheemps + Rexy: Doesn't check for a title, and if there is none then you can't open it.
No title now defaults to (no title).

Rexy: Bug: Blank box when viewing a sent PM. It's to the left of the clock. smile.gif Unless...it's just to take up space.
Was a bug... misspelled {$row['pt_title']} as {$row['title']} smile.gif.


Hmmmmmm?
Rexy: Clicking the Go Back link from the critical error window after sending a PM really just refreshes the page
Walk me through this... You make a pm... caused a critical error (how?) and then push back?

Sheemps: You need to put a limit on custom folder.
There is a limit... kinda. Eventually, if you use too many folders, your serialized data will outgrow the boundaries it has to fill in mysql and your entire array will just combust into meaningless nothingness, screwing things up everywhere for you. 65535 is kinda hard to fill though. The default start with 3 folders takes up 250 characters... With over-estimating, that's 250 folders! lol... what do you guys think a good limit is? 10? 20?

Rexy: Lot's a Re: Re: Re: after big conversations. How about it just says it once?
I dunno... what does everyone else think?

Rexy: What happened to those quote boxes?
Nothing. The quote bbcode isn't correctly working... sometimes it does, sometimes it doesn't... if that's what you are talking about. It's hawt though? smile.gif

Rexy: Fix IE CSS where it repeats the silver gradient image.
Show picture... sorry... just me being lazy. I tired.

Rexy: Make things like [ delete ] buttons? (form buttons)
I initially planned on making images for them later. Maybe I will just use buttons though.

Sheemps: Defiantely fix the word wrapping.
It's a bit hard to prevent huge unbroken strings. This has been an issue for like ever in every area with senv4. The biggest problem is some huge unbroken strings are okay to post... such as long urls or image paths. I'll ponder upon this for awhile, but for now, it'll be an issue from here on out, in every script.

Well, while looking for a different function in php, I stumbled upon wordwrap() (well, restumbled upon it). Fixxing this is probably a good possibility. Later though. smile.gif.

Sheemps: And on the block page, it says block notices and PMs, aren't notices only mod/admin sendable? If so, wouldn't that just meses up alot of things?
There are several types of notices... admin, friendship, clan, etc...
You can not block admin notices, and you wouldn't want to! You'll be able to ask for a second judgement on any action taken against you and the notice will send a request to the admin section, containing the ability for your post/signature/etc/etc/etc to be restored! Quite hot shit. In theory. It'll also contain such things as map / tutorial submission status and so forth.
The other type is unnecessary types like friendship, clan, and game requests. You could block such things from higher powers like me if you want, and they would be blocked.






Hopefully I covered every little report with a response or a question. I think I may take a nap and get on those saved/sent pm issues tomorrow.

You guys are great smile.gif cool1.gif. Even though I did state the message center was ready for playing with kinda early, it seems to help to finish it faster with you guys yelling what's wrong smile.gif.
Report, edit, etc...Posted by LegacyWeapon on 2005-06-11 at 01:11:39
This isn't really a bug but when you "Quick Reply", it will have quote BBCode like this:
CODE
"[QUOTE][/QUOTE]"
However, if you do a normal reply, it will have quote BBCode like this:
CODE
"[Quote][/Quote]"


Sending a Message with a spaces as the title will make the title blank and you can't open it.

I seem to have 2 pages of PMs yet I don't have any on the second page.

On the glitched second page, it will not show the pages available.

QUOTE
Rexy: Lot's a Re: Re: Re: after big conversations. How about it just says it once?
I dunno... what does everyone else think?
I thought v4 only did 1 RE:? I mean RE does mean "In reference to:" or "In regard to:"
Report, edit, etc...Posted by Shmeeps on 2005-06-11 at 01:28:48
QUOTE
The default start with 3 folders takes up 250 characters... With over-estimating, that's 250 folders! lol... what do you guys think a good limit is? 10? 20?

10 should probably be good, in my Yahoo I have 4 and only use two, so 10 should be good.

Report, edit, etc...Posted by IsolatedPurity on 2005-06-11 at 09:47:44
Still being worked on:
  • Check names + find names links (will probably do later on...)
  • Empty signature boxxes...
Should workd perfectly:
Custom folder limit
10.

Anything with saved messages
Might be a little buggy... I'm testing it now!
Edit: Seems okay! Somewhere along the lines I got out of sync though...

re: re: re: re:
Only one Re:... should there only be one Fwd: too? It somewhat means something if it's Fwd: Fwd:... maybe?

Mass altered functions (move, delete)
Test this one hardcore.

Sending a Message with a spaces as the title will make the title blank and you can't open it.
Added a trim function to a global "security" function... this should no longer be an issue with all new things... hopefully.

Anything with sent messages

I seem to have 2 pages of PMs yet I don't have any on the second page.
Check it blushing.gif

PM forwarding...
Check it out...


Other notes... I fixxed up some other bugs / planned items:
Now, you'll be able to see if a message you recieved has multiple recipents.
Messages will show "various: x" for the "sendees" column in sent / save if it's more than 1 recpient.
Mass select checkbox works.
Navigation should be visible everywhere.
Small tweaks in the pm sending function... nothing visible.


Because of my methods, there's no solid way to get a total message count on demand without adding another column in the database and trying to keep that in sync as well (... there is one little indirect way of doing it, I suppose).
But...
What if, after you reached your limit, you could still recieve messages, but couldn't send out until you clean up?
You wouldn't / couldn't be spammed passed your max messages as new pms. So if you could hold 100 pms, the most messages possible to be held in your inbox would be 199 (99 old, 100 new).
Or perhaps, it would be limited to 50 new pms no matter what your limit is?

Give thoughts.



Most importantly:
Constantly check to see if you're in sync. If it says you have 1 message in your inbox and it displays nothing... you're out of sync. If you have -1 messages, you're out of sync... etc.
I'll probably do a little debug information in the splash screen soon to give full details on your status.

I think it might be best if I had the script shut down during periods of lag.. if it's possible?
Either that or have a resync code somewhere. Maybe.

Other than that, some time today I'll be resetting the messages.
Report, edit, etc...Posted by BeeR_KeG on 2005-06-11 at 11:44:34
Alright, I've been testing for a while now and here's how it went.

Address books works fine. I can Add/Delete/Edit members and groups.
It would be nice if there was a feature to arrange your address book either by alphabetical order or by groups.

Mass deleting PM's by using the Empty Folders works fine.

Sending Mass Messages to a Address Book group works fine. It would also be nice if I could PM 2 or more groups at once.

QUOTE
You guys are great . Even though I did state the message center was ready for playing with kinda early, it seems to help to finish it faster with you guys yelling what's wrong .


Thats because for once, we get to be your Boss tongue.gif
Report, edit, etc...Posted by LegacyWeapon on 2005-06-11 at 14:01:20
QUOTE(isolatedpurity @ Jun 11 2005, 09:47 AM)
Anything with saved messages
Might be a little buggy... I'm testing it now!
Edit:  Seems okay!  Somewhere along the lines I got out of sync though...

Mass altered functions (move, delete)
Test this one hardcore.
[right][snapback]232465[/snapback][/right]
Update your http://www.staredit.net/index.php?showtopic=16323 topic.

The second page thing:
You forgot the inbox in the address.

Page 2 link: http://www.staredit.net/1337v5/?p=messages...a=pms&type=&s=1
Actual Page 2: http://www.staredit.net/1337v5/?p=messages...&type=inbox&s=1

Massive Delete after Moving to a different folder will have the number where the messages were in the first place subtracted.
Example: Moved 6 messages from Inbox to Folder1
Deleted 6 messages from Folder1
Inbox has -6 messages.
Folder1 has 6.
Report, edit, etc...Posted by Shmeeps on 2005-06-11 at 18:29:20
This might be just cause of the IE CSS that you metioned wasn't done or whatever, but this happens some of the times.

At the top in the middle, if you're confused.

[attachmentid=10270]

EDIT: Roffle, very nice MySQL error message.

[attachmentid=10271]

This isn't a big deal, but I think in IPB, when you check all the messages, it auto checks the "Select All" but it doesn't here. Not very important, but if it affects something, it might be.

[attachmentid=10274]

And in this one, when you delete something from the sent box, it still says you have something in there.

[attachmentid=10275]

Shown again, tested with the Delete All and Delete One message, both mess up. And I have a negative two in one folder...

[attachmentid=10276]

EDIT: I think I found it. When you delete it, it does something that messes up another, or non-existant fodler. I deleted two sent messages in one account, and have a negative two messages in one folder that has no name. On my other one, I deleted one, and have negative one messages in a folder without a name.
Report, edit, etc...Posted by Slyence on 2005-06-11 at 22:19:40
Hmm I noticed you can't send PMS to your self, Either this is a bug, Or you made it like this.

Also, When you try to use the BBCode tags while composing, It's border highlight's, And doesn't go into the message.
Report, edit, etc...Posted by chuiu on 2005-06-11 at 22:47:13
About Saved Drafts, when you go into to view one, it has the Save Draft button still. You can't save the current one if you edit it, but if you click the Save Draft button it creates a new one. How about a Save Draft button and a Save Changes button.
Report, edit, etc...Posted by Shmeeps on 2005-06-12 at 00:06:38
QUOTE
Hmm I noticed you can't send PMS to your self, Either this is a bug, Or you made it like this.

Also, When you try to use the BBCode tags while composing, It's border highlight's, And doesn't go into the message.

You can send PMs to your self. He hasn't finished the BBcode yet.
Report, edit, etc...Posted by LegacyWeapon on 2005-06-12 at 00:34:38
When trying to delete selected when none are selected causes this error:
CODE
Query failed : SELECT * FROM message_pms_topics WHERE o_mid = 21 AND pt_id IN ()
(1064): You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1


When trying to move selected when none are selected causes this error:
CODE
Query failed : UPDATE message_pms_topics SET folder='inbox' WHERE o_mid=21 AND pt_id IN ()
(1064): You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1


Trying to delete a folder with messages in it causes this error:
CODE
Query failed : UPDATE message_pms_text SET del_count=del_count+1 WHERE pm_id IN (Array)
(1054): Unknown column 'Array' in 'where clause'


Forwarding a message does not allow you to send it without an addition message. So I can't just forward it so that it only displays:
CODE
- - This message was sent by LegacyWeapon to LegacyWeapon: - -
[QUOTE][QUOTE]test<<>>[/QUOTE][/QUOTE]
I would need to add extra text in order to send it.
Report, edit, etc...Posted by Shmeeps on 2005-06-12 at 01:51:30
If you try to empty a folder that has 0 messages in it, it gives you this message:

QUOTE
Script Failed... invalid user input... If post/get, crashing value: 3


Maybe add something to stop them from checking folders with 0 messages, or just nullify it if they do.

Maybe also add a empty all on that page?

Here you should add a &nbsp; so it still gets the box. Looks kinda ugly if nothings in it. Maybe just change it to YES and NO?

[attachmentid=10285]

Next Page (2)