Report, edit, etc...Posted by SI on 2006-11-08 at 15:29:12
QUOTE(spinesheath @ Nov 8 2006, 03:24 PM)
This is NO dirty hack, this is just exactly how Starcraft works (well ok, the STR section really is not something Blizzard can show off with...), and if this were to be "fixed", it would probably mean that the algorithms all the other editors use will not work anymore just as well.
In my editor, this is an OPTION. If you want to maintain compatability, there is nothing that hinders you.
Well, your choice. I just made sure you know about this, nothing else.
[right][snapback]585711[/snapback][/right]
In my editor, this is an OPTION. If you want to maintain compatability, there is nothing that hinders you.
Well, your choice. I just made sure you know about this, nothing else.
[right][snapback]585711[/snapback][/right]
imo, the starcraft code that does it is a dirty hack, just because starcraft works like that doesn't make it pretty or correct. It works, yes, is it nice, no.
E: Actually scmdraft may be able to load a map with that fine, but it would't manage to save it
Report, edit, etc...Posted by Azu on 2006-11-08 at 20:28:39
What is so dirty about it? 
Report, edit, etc...Posted by SI on 2006-11-08 at 21:23:22
QUOTE(Azu @ Nov 8 2006, 08:28 PM)
What is so dirty about it?
[right][snapback]585929[/snapback][/right]
[right][snapback]585929[/snapback][/right]
its just not clean safe code... "Oh we'll take an unverified index and use it as a pointer and load whatever is at that offset, nevermind that its pointing to part of the offset table and not the data area"
Report, edit, etc...Posted by Azu on 2006-11-09 at 01:42:15
So.. could it mess up my computer..? Like make it crash or something? 
Report, edit, etc...Posted by spinesheath on 2006-11-09 at 02:11:41
Nope, no way to corrupt anything.
All the indexes Starcraft gets are unverified... There is no way to tell if the map has been hex-edited...
Starcraft does not read strings that are off the limits of the STR section, or strings with higher indexes than MaxStrIndex (formerly known as NumberOfStrings), this is noted somewhere in the topics I linked, btw.
And what is different from the code as you thought it was before? You were given an index and used it as a pointer, read an offset and used it as pointer. All the time... At least I hope so, I can't imagine how weird your code must be if you did it differently AND used string recycling...
Well, whatever. I informed you because you don't seem to check Blizzforums anymore.
All the indexes Starcraft gets are unverified... There is no way to tell if the map has been hex-edited...
Starcraft does not read strings that are off the limits of the STR section, or strings with higher indexes than MaxStrIndex (formerly known as NumberOfStrings), this is noted somewhere in the topics I linked, btw.
And what is different from the code as you thought it was before? You were given an index and used it as a pointer, read an offset and used it as pointer. All the time... At least I hope so, I can't imagine how weird your code must be if you did it differently AND used string recycling...
Well, whatever. I informed you because you don't seem to check Blizzforums anymore.